-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add all deprecations and warnings for React APIs #12746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
src/react/hooks/useLazyQuery.ts
Outdated
"useLazyQuery", | ||
"Use the `fetchPolicy` option instead." | ||
); | ||
useWarnRemovedOption(warnOpts, "partialRefetch", "useLazyQuery"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useWarnRemovedOption(warnOpts, "partialRefetch", "useLazyQuery"); | |
if (__DEV__) { | |
/* eslint-disable react-compiler/react-compiler */ | |
/* eslint-disable react-hooks/rules-of-hooks */ |
Let's wrap all of these in a if (__DEV__)
statement block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 8b64d1f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I meant the calls I commented on, but that too, yes :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp I read it wrong haha. Would you prefer to have the call to the hook stripped out or the function body stripped out? I suppose it might reduce more bundle size doing it this way ya?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok better version: 2ff87a2
Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
6180eb6
to
f8010eb
Compare
f8010eb
to
b585b38
Compare
size-limit report 📦
|
No description provided.