Skip to content

feat(core): DockerBuildOptions support network param #34725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #34514

Reason for this change

DockerRunOptions has network param but DockerBuildOptions doesn't

Description of changes

DockerBuildOptions support network param

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Test DockerImage.fromBuild with python-alpha/test/integ.function.custom-build

$ ps aux | grep "docker build"
superch+ 44036  0.1  0.1 1994552 26112 pts/0   Sl+  08:20   0:00 docker build -t cdk-5322298f1d5d198bb67c2885f92ffc76a9e60f4ec4b584a8df116ebc75ebc843 --network default /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/lambda-handler-custom-build

Test PythonLayerVersion with python-alpha/test/integ.function.project

$ ps aux | grep "docker build"
superch+ 76129  100  0.1 1920308 24064 pts/0   Sl+  09:09   0:00 docker build -t cdk-858025f5c9bccadc11d046a66c283180089509773bb117d94236a7e2c03a0295 --platform linux/amd64 --network default --build-arg IMAGE=public.ecr.aws/sam/build-python3.13 /workspaces/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@phuhung273 phuhung273 requested a review from a team as a code owner June 15, 2025 09:56
@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2025 09:56
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jun 15, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a1ff727
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda_python_alpha: BundlingOptions network parameter is ignored
2 participants