feat(kinesisfirehose): support custom time zone settings for S3 destination #34738
+191
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34737.
Reason for this change
Amazon Data Firehose supports to configure the time zone of timestamps in S3 object prefix.
For details, see https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html#timestamp-namespace
Description of changes
Added the
timeZoneprop toS3BucketPropsinterface to setExtendedS3Destination.CustomTimeZone.Note: Not in
CommonPropssince onlyExtendedS3DestinationConfigurationsupports time zone.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit test and integ test.
I've confirmed setting timeZone reflects to Firehose's console.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license