-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(bedrock-alpha): add guardrails l2 construct #34765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrail-filters.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments to the guardrail-filters file, with some changes that will need to be done. Not done with the other files, but for now you can start working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments and requested changes for the guardrail.ts
file
packages/@aws-cdk/aws-bedrock-alpha/bedrock/guardrails/guardrails.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @alvazjor this is ready for approval, thanks ! |
…s-cdk into bedrock-guardrails-l2
@alvazjor addressed last comments, ready for approval |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Adding new feature
Description of changes
Add to the bedrock alpha construct support for bedrock guardrails through a new L2 construct
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license