Skip to content

Conversation

krokoko
Copy link
Contributor

@krokoko krokoko commented Jun 19, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Adding new feature

Description of changes

Add to the bedrock alpha construct support for bedrock guardrails through a new L2 construct

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jun 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 19, 2025 20:00
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@krokoko krokoko changed the title feat(Bedrock-alpha): add guardrails l2 construct feat(bedrock-alpha): add guardrails l2 construct Jun 19, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 19, 2025 20:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@krokoko krokoko mentioned this pull request Jun 19, 2025
2 tasks
@krokoko krokoko marked this pull request as ready for review July 3, 2025 21:52
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 3, 2025
@alvazjor alvazjor added contribution/core This is a PR that came from AWS. and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 10, 2025
@alvazjor alvazjor self-assigned this Jul 10, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 10, 2025
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments to the guardrail-filters file, with some changes that will need to be done. Not done with the other files, but for now you can start working on it

Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments and requested changes for the guardrail.ts file

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 759a8cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alvazjor alvazjor added p1 and removed p2 labels Aug 12, 2025
@krokoko krokoko requested a review from alvazjor August 15, 2025 22:39
@krokoko
Copy link
Contributor Author

krokoko commented Aug 18, 2025

Hi @alvazjor this is ready for approval, thanks !

@krokoko krokoko requested a review from alvazjor August 19, 2025 15:01
@krokoko
Copy link
Contributor Author

krokoko commented Aug 19, 2025

@alvazjor addressed last comments, ready for approval

Copy link
Contributor

mergify bot commented Aug 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Aug 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b4fdb2b into aws:main Aug 26, 2025
17 of 18 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants