refactor: move attestation initialization server side #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
changed the title
migmartri
commented
Jul 4, 2025
| @@ -51,6 +51,11 @@ func newWorkflowCreateCmd() *cobra.Command { | |||
| // Try to find it by name | |||
| c, err := action.NewWorkflowContractDescribe(actionOpts).Run(contractRef, 0) | |||
| if err != nil || c == nil { | |||
| _, err := action.LoadFileOrURL(contractRef) | |||
There was a problem hiding this comment.
this is just to improve this other command error message, not specifically about this problem.
javirln
approved these changes
Jul 4, 2025
|
marked it as draft to enable server side contract validation |
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the attestation initialization process to the server this includes:
If the workflow doesn't exist
If the workflow exists
This changes is an improvement since it makes the process fully compatible with federated authentication as well a pre-requisite for #2190