Skip to content

Commit 04c44a8

Browse files
[xabt] remove unused MSBuild tasks (#10209)
Context: #10206 @copilot found these in #10206, so I checked their usage one-by-one to remove completely unused code. Many of these look *very* old, like `<GetConvertedJavaLibraries/>` for example, mentions an old Android tool named `jack`. Removing the `<UsingTask>` declarations should also slightly improve MSBuild evaluation time. From what I've seen profiling in the past, MSBuild creates a full path string for each `AssemblyFile` entry.
1 parent 48fdbad commit 04c44a8

File tree

8 files changed

+0
-265
lines changed

8 files changed

+0
-265
lines changed

Documentation/docs-mobile/messages/index.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -267,19 +267,15 @@ and `NNN` is a 3 digit number indicating the type of the unhandled `Exception`.
267267
* `BBA` - `BuildBaseAppBundle`
268268
* `BGN` - `BindingsGenerator`
269269
* `BLD` - `BuildApk`
270-
* `CAL` - `CreateAdditionalLibraryResourceCache`
271-
* `CAR` - `CalculateAdditionalResourceCacheDirectories`
272270
* `CCR` - `CopyAndConvertResources`
273271
* `CCV` - `ConvertCustomView`
274272
* `CDF` - `ConvertDebuggingFiles`
275273
* `CDJ` - `CheckDuplicateJavaLibraries`
276274
* `CFI` - `CheckForInvalidResourceFileNames`
277-
* `CFR` - `CheckForRemovedItems`
278275
* `CGJ` - `CopyGeneratedJavaResourceClasses`
279276
* `CGS` - `CheckGoogleSdkRequirements`
280277
* `CIC` - `CopyIfChanged`
281278
* `CIL` - `CilStrip`
282-
* `CLA` - `CollectLibraryAssets`
283279
* `CLC` - `CalculateLayoutCodeBehind`
284280
* `CLP` - `ClassParse`
285281
* `CLR` - `CreateLibraryResourceArchive`
@@ -290,7 +286,6 @@ and `NNN` is a 3 digit number indicating the type of the unhandled `Exception`.
290286
* `CNE` - `CollectNonEmptyDirectories`
291287
* `CNL` - `CreateNativeLibraryArchive`
292288
* `CPD` - `CalculateProjectDependencies`
293-
* `CPF` - `CollectPdbFiles`
294289
* `CPI` - `CheckProjectItems`
295290
* `CPR` - `CopyResource`
296291
* `CPT` - `ComputeHash`
@@ -311,7 +306,6 @@ and `NNN` is a 3 digit number indicating the type of the unhandled `Exception`.
311306
* `GAR` - `GetAdditionalResourcesFromAssemblies`
312307
* `GAS` - `GetAppSettingsDirectory`
313308
* `GCB` - `GenerateCodeBehindForLayout`
314-
* `GCJ` - `GetConvertedJavaLibraries`
315309
* `GEP` - `GetExtraPackages`
316310
* `GFT` - `GetFilesThatExist`
317311
* `GIL` - `GetImportedLibraries`

src/Xamarin.Android.Build.Tasks/Tasks/CalculateAdditionalResourceCacheDirectories.cs

Lines changed: 0 additions & 44 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Tasks/CheckForRemovedItems.cs

Lines changed: 0 additions & 43 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Tasks/CollectLibraryAssets.cs

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Tasks/CollectPdbFiles.cs

Lines changed: 0 additions & 51 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Tasks/CreateAdditionalLibraryResourceCache.cs

Lines changed: 0 additions & 55 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Tasks/GetConvertedJavaLibraries.cs

Lines changed: 0 additions & 33 deletions
This file was deleted.

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,13 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
3838
<UsingTask TaskName="Xamarin.Android.Tasks.CalculateAdditionalResourceCacheDirectories" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
3939
<UsingTask TaskName="Xamarin.Android.Tasks.CalculateLayoutCodeBehind" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4040
<UsingTask TaskName="Xamarin.Android.Tasks.CalculateProjectDependencies" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
41-
<UsingTask TaskName="Xamarin.Android.Tasks.CheckForRemovedItems" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4241
<UsingTask TaskName="Xamarin.Android.Tasks.CheckForInvalidResourceFileNames" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4342
<UsingTask TaskName="Xamarin.Android.Tasks.CheckClientHandlerType" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4443
<UsingTask TaskName="Xamarin.Android.Tasks.CollectAssemblyFilesToCompress" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4544
<UsingTask TaskName="Xamarin.Android.Tasks.CollectDalvikFilesForArchive" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4645
<UsingTask TaskName="Xamarin.Android.Tasks.CollectJarContentFilesForArchive" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4746
<UsingTask TaskName="Xamarin.Android.Tasks.CollectNativeFilesForArchive" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
4847
<UsingTask TaskName="Xamarin.Android.Tasks.CollectNonEmptyDirectories" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
49-
<UsingTask TaskName="Xamarin.Android.Tasks.CollectPdbFiles" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5048
<UsingTask TaskName="Xamarin.Android.Tasks.CollectRuntimeConfigFilesForArchive" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5149
<UsingTask TaskName="Xamarin.Android.Tasks.CollectTypeMapFilesForArchive" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5250
<UsingTask TaskName="Xamarin.Android.Tasks.CompressAssemblies" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
@@ -55,7 +53,6 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
5553
<UsingTask TaskName="Xamarin.Android.Tasks.ConvertCustomView" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5654
<UsingTask TaskName="Xamarin.Android.Tasks.CopyIfChanged" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5755
<UsingTask TaskName="Xamarin.Android.Tasks.CopyResource" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
58-
<UsingTask TaskName="Xamarin.Android.Tasks.CreateAdditionalLibraryResourceCache" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
5956
<UsingTask TaskName="Xamarin.Android.Tasks.CreateAssemblyStore" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
6057
<UsingTask TaskName="Xamarin.Android.Tasks.CreateMsymManifest" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
6158
<UsingTask TaskName="Xamarin.Android.Tasks.CreateResgenManifest" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
@@ -79,7 +76,6 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
7976
<UsingTask TaskName="Xamarin.Android.Tasks.GenerateTypeMappings" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
8077
<UsingTask TaskName="Xamarin.Android.Tasks.GetAndroidDefineConstants" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
8178
<UsingTask TaskName="Xamarin.Android.Tasks.GetAppSettingsDirectory" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
82-
<UsingTask TaskName="Xamarin.Android.Tasks.GetConvertedJavaLibraries" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
8379
<UsingTask TaskName="Xamarin.Android.Tasks.GetFilesThatExist" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
8480
<UsingTask TaskName="Xamarin.Android.Tasks.GetMonoPlatformJar" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
8581
<UsingTask TaskName="Xamarin.Android.Tasks.KeyTool" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
@@ -99,12 +95,9 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
9995
<UsingTask TaskName="Xamarin.Android.Tasks.RewriteMarshalMethods" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
10096
<UsingTask TaskName="Xamarin.Android.Tasks.GetExtraPackages" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
10197
<UsingTask TaskName="Xamarin.Android.Tasks.CopyGeneratedJavaResourceClasses" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
102-
<UsingTask TaskName="Xamarin.Android.Tasks.ReadJavaStubsCache" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
103-
<UsingTask TaskName="Xamarin.Android.Tasks.ScanAssemblies" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
10498
<UsingTask TaskName="Xamarin.Android.Tasks.SplitProperty" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
10599
<UsingTask TaskName="Xamarin.Android.Tasks.CheckProjectItems" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
106100
<UsingTask TaskName="Xamarin.Android.Tasks.CheckDuplicateJavaLibraries" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
107-
<UsingTask TaskName="Xamarin.Android.Tasks.CollectLibraryAssets" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
108101
<UsingTask TaskName="Xamarin.Android.Tasks.CompileNativeAssembly" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
109102
<UsingTask TaskName="Xamarin.Android.Tasks.LinkApplicationSharedLibraries" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />
110103
<UsingTask TaskName="Xamarin.Android.Tasks.PrepareAbiItems" AssemblyFile="Xamarin.Android.Build.Tasks.dll" />

0 commit comments

Comments
 (0)