[native] More std::string_view use for consistency and safety
#10164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces use of raw const char* parameters with std::string_view for consistency and safety in DSO loading and file/path utilities.
- Converted DSO loading functions and related declarations to use
std::string_view - Updated utility functions in
util.hhwith newfile_exists_no_null_checkand astd::string_viewoverload - Added
is_path_rootedhelper and adjusted calls to usestring_viewdata and size
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/native/clr/runtime-base/android-system.cc | Changed DSO loader methods to accept std::string_view, updated .data() usage |
| src/native/clr/include/runtime-base/util.hh | Added file_exists_no_null_check, file_exists(std::string_view), and is_path_rooted |
| src/native/clr/include/runtime-base/monodroid-dl.hh | Included <string_view> and updated all const char* overloads to std::string_view |
| src/native/clr/include/runtime-base/android-system.hh | Updated declarations to match new std::string_view signatures |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 3, 2025
grendello
changed the title
std::string_view use for consistency and safetystd::string_view use for consistency and safety
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
grendello
force-pushed
the
dev/grendel/clr-more-string_view
branch
from
e0f4230 to
d2f8ee2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.