Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 16, 2025

The mkbundle feature was only available in Xamarin.Android but was never implemented in .NET 6+. Since this repository now targets .NET 10, all mkbundle-related functionality should be removed.

Changes Made

  • Removed main task: Deleted src/Xamarin.Android.Build.Tasks/Tasks/MakeBundleNativeCodeExternal.cs (274 lines)
  • Removed tests: Deleted src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/MakeBundleNativeCodeExternalTests.cs (73 lines)
  • Removed MSBuild integration: Removed UsingTask declaration from Xamarin.Android.Common.targets
  • Removed error codes: Cleaned up XA5102, XA5103, and XA5201 from all localized resource files:
    • XA5102: "Conversion from assembly to native code failed. Exit code {0}"
    • XA5103: "NDK C compiler exited with an error. Exit code {0}"
    • XA5201: "NDK linker exited with an error. Exit code {0}"
  • Removed documentation: Deleted MBN task prefix reference from Documentation/docs-mobile/messages/index.md
  • Removed test project: Deleted entire tests/CodeGen-MkBundle/ directory containing mkbundle-specific test application

Verification

  • Confirmed no remaining references to MakeBundleNativeCodeExternal in the codebase
  • Preserved unrelated comments that mention mkbundle in general contexts (NDK tooling documentation)
  • All changes are deletions with minimal modifications, maintaining code integrity

The removal is safe since mkbundle functionality was never available in .NET 6+ and this repository targets .NET 10.

Fixes #10207.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove Xamarin.Android.Tasks.MakeBundleNativeCodeExternal Remove MakeBundleNativeCodeExternal task and mkbundle functionality Jun 16, 2025
@Copilot Copilot AI requested a review from jonathanpeppers June 16, 2025 18:01
Copilot finished work on behalf of jonathanpeppers June 16, 2025 18:01
@jonathanpeppers
Copy link
Member

Will review this again after:

Which, will hopefully fix @copilot:
image

@copilot you can give a try if you like?

@jonathanpeppers
Copy link
Member

@copilot try again now, with changes from main.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 16, 2025

@copilot try again now, with changes from main.

Fixed the blank line issues in the resource files and documentation. Removed extra blank lines from:

  • Documentation/docs-mobile/messages/index.md
  • src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
  • src/Xamarin.Android.Build.Tasks/Properties/Resources.resx

Changes committed in 61be1e7.

Copilot finished work on behalf of jonathanpeppers June 16, 2025 20:41
@jonathanpeppers jonathanpeppers marked this pull request as ready for review June 16, 2025 20:58
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) June 16, 2025 20:59
@jonathanpeppers jonathanpeppers merged commit 35fe767 into main Jun 16, 2025
59 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10207 branch June 16, 2025 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Error loading sessions

Retrying...

Successfully merging this pull request may close these issues.

Remove Xamarin.Android.Tasks.MakeBundleNativeCodeExternal
2 participants