-
Notifications
You must be signed in to change notification settings - Fork 556
Remove MakeBundleNativeCodeExternal
task and mkbundle functionality
#10208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Xamarin.Android.Tasks.MakeBundleNativeCodeExternal
MakeBundleNativeCodeExternal
task and mkbundle functionality
Copilot finished work on behalf of
jonathanpeppers
June 16, 2025 18:01
src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
Copilot stopped work on behalf of
jonathanpeppers due to an error
June 16, 2025 18:24
Copilot stopped work on behalf of
jonathanpeppers due to an error
June 16, 2025 19:47
@copilot try again now, with changes from main. |
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Fixed the blank line issues in the resource files and documentation. Removed extra blank lines from:
Changes committed in 61be1e7. |
Copilot finished work on behalf of
jonathanpeppers
June 16, 2025 20:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mkbundle
feature was only available in Xamarin.Android but was never implemented in .NET 6+. Since this repository now targets .NET 10, all mkbundle-related functionality should be removed.Changes Made
src/Xamarin.Android.Build.Tasks/Tasks/MakeBundleNativeCodeExternal.cs
(274 lines)src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/MakeBundleNativeCodeExternalTests.cs
(73 lines)UsingTask
declaration fromXamarin.Android.Common.targets
Documentation/docs-mobile/messages/index.md
tests/CodeGen-MkBundle/
directory containing mkbundle-specific test applicationVerification
MakeBundleNativeCodeExternal
in the codebaseThe removal is safe since mkbundle functionality was never available in .NET 6+ and this repository targets .NET 10.
Fixes #10207.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.