Remove <CreateMsymManifest/> MSBuild task and $(MonoSymbolArchive) property
#10221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
<CreateMsymManifest/> MSBuild task and $(MonoSymbolArchive) property<CreateMsymManifest/> MSBuild task and $(MonoSymbolArchive) property
Copilot finished work on behalf of
jonathanpeppers
June 17, 2025 22:15
… lines Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Removed all additional mono-symbolicate references including the tools/scripts/mono-symbolicate script, mono-symbolicate from _MonoScript items, and MonoSymbolArchive property from DefaultProperties.targets. Fixed in 9810216. |
jonathanpeppers
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy mono-symbolicate support components that were never implemented for .NET 6+ as requested in the issue.
Changes Made
Removed Task Classes:
CreateMsymManifestMSBuild task (src/Xamarin.Android.Build.Tasks/Tasks/CreateMsymManifest.cs)MonoSymbolicateMSBuild task (src/Xamarin.Android.Build.Tasks/Tasks/MonoSymbolicate.cs)Updated MSBuild Targets (
Xamarin.Android.Common.targets):$(MonoSymbolArchive)property definitions and conditions$(_AndroidSequencePointsMode)logic (removed MonoSymbolArchive dependencies)$(_MSYMDirectory)property definitionUpdated Documentation:
Preserved:
Microsoft.Android.Sdk.DefaultProperties.targetsthat setsMonoSymbolArchive=falsefor .NET compatibilityTasks/Aot.cs(separate functionality unrelated to mono-symbolicate tool)Verification
The changes are surgical and minimal, removing only the specific mono-symbolicate functionality while preserving all other build system functionality.
Fixes #10220.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.