Skip to content

Remove android-net8 workload #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Remove android-net8 workload #10228

merged 4 commits into from
Jun 19, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 18, 2025

We temporarily added support for net8.0-android projects in .NET 10:

We no longer need this, as .NET 8 MAUI is out of support: https://aka.ms/maui-support-policy

This PR removes:

  • The android-net8 workload definition from WorkloadManifest.in.json
  • The Microsoft.Android.Sdk.net8 pack definition
  • .NET 8.0 framework imports and references from WorkloadManifest.in.targets
  • android-net8 from workload installation arguments in Directory.Build.targets
  • net8.0-android test cases that were building .NET 8 Android projects

The changes are minimal and surgical, removing only the specific .NET 8 Android workload support while preserving all other functionality.

Fixes #10227.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove android-net8 workload Remove android-net8 workload Jun 18, 2025
@Copilot Copilot AI requested a review from jonathanpeppers June 18, 2025 21:19
Copilot finished work on behalf of jonathanpeppers June 18, 2025 21:19
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove all instances of $(AndroidNet8PreviousVersion).

There are also some tests that do things like:

		static readonly object[] DotNetPackTargetFrameworks = new object[] {
			new object[] {
				"net8.0",
				"android",
				34,
			},

We should remove the test cases like this for net8.0.

….in.targets

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 18, 2025

We should also remove all instances of $(AndroidNet8PreviousVersion).

There are also some tests that do things like:
...

Fixed in commit a854f42. Removed all instances of $(AndroidNet8PreviousVersion) from eng/Versions.props and build-tools/create-packs/Microsoft.NET.Sdk.Android.proj, and removed the net8.0 test cases from both DotNetPackTargetFrameworks and DotNetTargetFrameworks arrays in XASdkTests.cs.

Copilot finished work on behalf of jonathanpeppers June 18, 2025 21:58
@Copilot Copilot AI requested a review from jonathanpeppers June 18, 2025 21:58
@jonathanpeppers
Copy link
Member

This looks good, but I'm going to wait until we branch for the next .NET 10 preview to merge this.

@copilot make no further changes, but do a quick verification that this is the inverse of: aa0485f

Check if we missed anything.

Copy link
Contributor Author

Copilot AI commented Jun 19, 2025

This looks good, but I'm going to wait until we branch for the next .NET 10 preview to merge this.

@copilot make no further changes, but do a quick verification that this is the inverse of: https:/...

I've verified that the changes are the inverse of commit aa0485f. The cleanup successfully removes:

✅ All AndroidNet8PreviousVersion references from eng/Versions.props and build tools
✅ The android-net8 workload definition and pack from WorkloadManifest.in.json
✅ .NET 8.0 framework imports and references from WorkloadManifest.in.targets
android-net8 from workload installation arguments
net8.0 test cases from both DotNetPackTargetFrameworks and DotNetTargetFrameworks arrays
net8.0-android from device integration test parameters

The changes precisely undo the temporary .NET 8 support that was added. All net8.0 references have been removed while preserving net9.0 and net10.0 support.

Copilot finished work on behalf of jonathanpeppers June 19, 2025 02:26
@jonathanpeppers jonathanpeppers marked this pull request as ready for review June 19, 2025 14:46
@jonathanpeppers jonathanpeppers merged commit a1b8427 into main Jun 19, 2025
60 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10227 branch June 19, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove android-net8 workload
2 participants