-
Notifications
You must be signed in to change notification settings - Fork 551
Remove android-net8
workload
#10228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove android-net8
workload
#10228
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
android-net8
workloadandroid-net8
workload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove all instances of $(AndroidNet8PreviousVersion)
.
There are also some tests that do things like:
static readonly object[] DotNetPackTargetFrameworks = new object[] {
new object[] {
"net8.0",
"android",
34,
},
We should remove the test cases like this for net8.0
.
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.targets
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.targets
Outdated
Show resolved
Hide resolved
….in.targets Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Fixed in commit a854f42. Removed all instances of |
I've verified that the changes are the inverse of commit aa0485f. The cleanup successfully removes: ✅ All The changes precisely undo the temporary .NET 8 support that was added. All net8.0 references have been removed while preserving net9.0 and net10.0 support. |
We temporarily added support for
net8.0-android
projects in .NET 10:We no longer need this, as .NET 8 MAUI is out of support: https://aka.ms/maui-support-policy
This PR removes:
android-net8
workload definition fromWorkloadManifest.in.json
Microsoft.Android.Sdk.net8
pack definitionWorkloadManifest.in.targets
android-net8
from workload installation arguments inDirectory.Build.targets
net8.0-android
test cases that were building .NET 8 Android projectsThe changes are minimal and surgical, removing only the specific .NET 8 Android workload support while preserving all other functionality.
Fixes #10227.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.