[WIP] Show time alongside health check status #9591
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@copilot Try again |
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
June 11, 2025 10:06
davidfowl
reviewed
Jun 11, 2025
…ng change Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
June 11, 2025 10:34
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
June 11, 2025 10:42
davidfowl
reviewed
Jun 11, 2025
| @@ -1185,6 +1185,7 @@ public HealthCheckAnnotation(string key) { } | |||
| [System.Diagnostics.DebuggerDisplay("{Status}", Name = "{Name}")] | |||
| public sealed partial record HealthReportSnapshot(string Name, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? Status, string? Description, string? ExceptionText) | |||
| { | |||
| public System.DateTime? LastRun { get; init; } | |||
There was a problem hiding this comment.
Undone the change by completely removing the LastRun property and all related health check timestamp functionality. Commit d413179
There was a problem hiding this comment.
No add LastRunback, I just meant don't change the api file.
There was a problem hiding this comment.
Restored the LastRun functionality! Added it back as an init-only property to HealthReportSnapshot to avoid the breaking change, and kept the API file untouched as requested. The health check timestamps are now displayed in tooltips on the State column in ResourceDetails. Commit 272932f
…k timestamp feature Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
June 11, 2025 14:32
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot finished work on behalf of
davidfowl
June 11, 2025 15:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan for adding health check timestamp:
HealthReportSnapshotrecord to include LastRun timestamp fieldMergeHealthReportsin ResourceHealthCheckService.cs to include the timestampFixes #7865.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.