ParallelOptions not being passed to Parallel.ForEachAsync in FindAppHostProjectFilesAsync #9661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostProjectFilesAsync
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the configured ParallelOptions (specifically MaxDegreeOfParallelism) is actually passed into the Parallel.ForEachAsync call in FindAppHostProjectFilesAsync, fixing an oversight where parallel options were never applied.
- Pass
parallelOptionsintoParallel.ForEachAsync. - No other functional changes.
davidfowl
reviewed
Jun 3, 2025
| @@ -41,7 +41,7 @@ private async Task<List<FileInfo>> FindAppHostProjectFilesAsync(DirectoryInfo se | |||
| MaxDegreeOfParallelism = Environment.ProcessorCount | |||
| }; | |||
|
|
|||
| await Parallel.ForEachAsync(projectFiles, async (projectFile, ct) => | |||
| await Parallel.ForEachAsync(projectFiles, parallelOptions, async (projectFile, ct) => | |||
There was a problem hiding this comment.
appHostProjects needs to have a lock around it or be concurrent collection.
There was a problem hiding this comment.
i think that is this pr #9655
mitchdenny
approved these changes
Jun 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate