-
Notifications
You must be signed in to change notification settings - Fork 647
Add DocumentDB Support #9666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DocumentDB Support #9666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for DocumentDB by introducing new resource classes, builder extensions, and playground projects to demonstrate local development and integration. Key changes include the creation of DocumentDB resource types (server and database), builder extension methods to register and configure DocumentDB resources, and playground projects with configuration files and sample API services.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/Aspire.Hosting.DocumentDB/DocumentDBServerResource.cs | Implements a DocumentDB server resource with connection string building logic. |
src/Aspire.Hosting.DocumentDB/DocumentDBDatabaseResource.cs | Defines the DocumentDB database resource as a child of the server resource. |
src/Aspire.Hosting.DocumentDB/DocumentDBContainerImageTags.cs | Provides container image tag constants but note a discrepancy with the documented registry value. |
src/Aspire.Hosting.DocumentDB/DocumentDBBuilderExtensions.cs | Contains extension methods to add and configure DocumentDB resources in the application model. |
Playground project files | Demo configuration and sample API service for DocumentDB integration. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.DocumentDB/DocumentDBBuilderExtensions.cs:61
- [nitpick] The local variable 'DocumentDBContainer' should follow camelCase naming conventions (e.g., 'documentDbContainer').
var DocumentDBContainer = new DocumentDBServerResource(name, userName?.Resource, passwordParameter, tls, allowInsecureTls);
internal static class DocumentDBContainerImageTags | ||
{ | ||
/// <remarks>ghcr.io/microsoft/documentdb</remarks> | ||
public const string Registry = "ghcr.io/guanzhousongmicrosoft"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value for 'Registry' does not match the remark comment ('ghcr.io/microsoft/documentdb') above. Please verify and update the registry URL to ensure consistency.
public const string Registry = "ghcr.io/guanzhousongmicrosoft"; | |
public const string Registry = "ghcr.io/microsoft/documentdb"; |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry for the confusion, I am working on the registry fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this should probably be hosted on mcr.microsoft.com right if its an officially built/signed image?
We have a conversation with the team about where this will live |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist
<remarks />
and<code />
elements on your triple slash comments?doc-idea
templatebreaking-change
templatediagnostic
template