Launch cli with proper params, remove unused strings and old command logic #9684

adamint · 2025-06-04T16:10:21Z

13 of the files are just updated nls files.

Removes the old aspire run and aspire add command logic
Shows an error when commands are run outside of a workspace
Runs commands in terminal with the switch --language (this shouldn't be an environment variable because the language can change over the extension lifetime, we cannot update existing terminal environment variables, and should not create another terminal after language changes)
Sets ASPIRE_EXTENSION_ENDPOINT_URL, ASPIRE_EXTENSION_TOKEN, and ASPIRE_EXTENSION_PROMPT_ENABLED environment variables before running cli commands

davidfowl · 2025-06-04T16:21:30Z

extension/src/commands/run.ts

-        terminal.sendText(`aspire run --project "${selectedProject}"`);
-        terminal.show();
-    }
+    terminal.sendText(`aspire run --language ${vscode.env.language}`);


What's --language?

CLI needs to know the vs code user’s current locale so that when it sends text back, that text is localized. —language is a switch that will need to be added to the cli to enable that, but for now can do nothing

Why is this a command line option instead of an environment variable?

It’s mentioned in the description

this shouldn't be an environment variable because the language can change over the extension lifetime, we cannot update existing terminal environment variables, and should not create another terminal after language changes

we should reuse the same terminal for the entire lifetime of the extension, but you can’t update the env of an existing vsc terminal, so it shouldn’t be an env variable at all

aspire run delegates to the apphost, the application owns the argument list. We will need to split application args from aspire cli args to make this work. It might be aspire [args] run [app args]

Gotcha, we should consider doing that then
@mitchdenny

I think for extension to CLI option passing we should just use environment variables since its not a mechanism that we would expect anything other than the extension to use.

Gotcha, wll convert to env variable. We just need to be aware of the small tradeoff we make doing that

Copilot

Pull Request Overview

This PR updates the CLI launch behavior by removing deprecated command logic and using a proper terminal language parameter. It removes unused project file helper functions, updates the RPC server to include a full address, and revises the run and add commands to check for a workspace before executing commands.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
extension/src/utils/projects.ts	Removed unused functions that handled project file retrieval and selection.
extension/src/server/rpcServer.ts	Added a new fullAddress property to the RPC server information.
extension/src/extension.ts	Changed rpcServerInfo to be exported for broader access.
extension/src/constants/strings.ts	Removed outdated command strings and added a noWorkspaceOpen message.
extension/src/commands/run.ts	Updated run command to use --language; added a workspace check but without error messaging.
extension/src/commands/add.ts	Simplified add command by removing package selection logic and including a workspace check.
Various package.nls.*.json files	Updated localization files to remove old command strings and include the noWorkspaceOpen message.

extension/src/commands/run.ts

extension/src/commands/add.ts

mitchdenny · 2025-06-05T23:34:29Z

extension/src/commands/run.ts

-        terminal.sendText(`aspire run --project "${selectedProject}"`);
-        terminal.show();
-    }
+    terminal.sendText(`aspire --language ${vscode.env.language} run`);


Not sure we'll need --language? But maybe I haven't thought about it enough.

Let’s just make it work without language for now @adamint

mitchdenny · 2025-06-05T23:36:55Z

extension/src/server/rpcServer.ts

+            const addressInfo = rpcServer?.address();
+            if (typeof addressInfo === 'object' && addressInfo?.port) {
+                outputChannelWriter.appendLine(rpcServerListening(addressInfo.port));
+                const fullAddress = `http://localhost:${addressInfo.port}`;


Does the RPC have the mechanism to use unix sockets or is only http possible?

Yes, just the address here is wrong. Removed the protocol

mitchdenny

Happy to get this in and then we can work on the CLI side (pending changing the language to an environment variable).

adamint added 3 commits June 4, 2025 11:48

set environment variables when creating terminal, remove old code

2f3fb68

Remove unused strings, fail when no workspace is open

4cf675f

extract isWorkspaceOpen to common function to prevent duplication

0a70652

adamint requested review from davidfowl, mitchdenny and Copilot June 4, 2025 16:10

github-actions bot added the needs-area-label label Jun 4, 2025

adamint changed the title ~~Launch cli with proper params, remove unused strings~~ Launch cli with proper params, remove unused strings and old command logic Jun 4, 2025

adamint requested a review from danmoseley June 4, 2025 16:15

davidfowl reviewed Jun 4, 2025

View reviewed changes

Copilot AI reviewed Jun 4, 2025

View reviewed changes

extension/src/commands/run.ts Show resolved Hide resolved

extension/src/commands/add.ts Show resolved Hide resolved

move --language to before command

02294dd

adamint added area-extension and removed needs-area-label labels Jun 4, 2025

delete unused test file

436f015

mitchdenny reviewed Jun 5, 2025

View reviewed changes

mitchdenny approved these changes Jun 5, 2025

View reviewed changes

remove --language, add lang env variable, fix full address

bd63dad

adamint enabled auto-merge (squash) June 6, 2025 18:18

adamint merged commit f0edddc into dotnet:main Jun 6, 2025
496 of 498 checks passed

Launch cli with proper params, remove unused strings and old command logic #9684

Launch cli with proper params, remove unused strings and old command logic #9684

Uh oh!

Conversation

adamint commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamint Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchdenny left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adamint commented Jun 4, 2025 •

edited

Loading

adamint Jun 4, 2025 •

edited

Loading

davidfowl Jun 4, 2025 •

edited

Loading

mitchdenny left a comment •

edited

Loading