[CI] Fail tests validation run if vscode extensions tests fail #9691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-engineering-systems
radical
added
the
NO-MERGE
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes in the CI workflow to ensure that the tests validation run fails if any dependency job fails, including the VS Code extensions tests.
- Update the command to package the VSIX file
- Reformat the dependency list for better readability
- Add an explicit step to exit with an error when any dependency fails
Comments suppressed due to low confidence (1)
.github/workflows/tests.yml:210
- The command 'np' looks like a typo for 'npx', which could unintentionally cause the VSIX packaging to fail. Consider reverting to 'npx' if this is not an intentional change.
run: np @vscode/vsce package --yarn --pre-release -o out/aspire-extension.vsix
…obs instead of using special files
radical
changed the title
radical
removed
the
NO-MERGE
radical
added
the
NO-MERGE
radical
removed
the
NO-MERGE
radical
commented
Jun 5, 2025
joperezr
reviewed
Jun 5, 2025
| @@ -178,7 +178,7 @@ jobs: | |||
| requiresTestSdk: true | |||
|
|
|||
| endtoend_tests: | |||
| name: EndToEnd ${{ matrix.os }} | |||
| name: EndToEnd Linux | |||
There was a problem hiding this comment.
Assuming in the future we plan on adding the windows and osx matrix and then we'll revert this back?
joperezr
reviewed
Jun 5, 2025
| - name: Compute result | ||
| - name: Fail if any dependency failed | ||
| # 'skipped' can be when a transitive dependency fails and the dependent job gets 'skipped'. | ||
| # For example, one of setup_* jobs failing and the Integration test jobs getting 'skipped' |
There was a problem hiding this comment.
Do we have a list of all potential values for result? Wondering if it would be best to compare if result does not equal success
joperezr
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using special
test-job-resultfiles, use a simplified condition that checks the results of all the jobs and fails the run if any of them has failed. This simplifies the whole thing and automatically adds support for the vscode extensions job.This also means that the number of artifacts produced is reduced by a lot.
Fixes #9690