Fix FileStream.FlushAsync documentation to correctly describe its behavior #11471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
FileStream.FlushAsync(CancellationToken)
incorrectly stated that it "causes any buffered data to be written to the underlying device". This is inaccurate based on the behavior change implemented in dotnet/coreclr#24902.Issue
The current documentation was misleading because:
FlushAsync()
behaves likeFlush()/Flush(false)
- it only flushes .NET stream buffers to the fileFlush(true)
actually performs the expensive operation of flushing OS buffers to diskChanges
Flush(true)
when flushing to the underlying storage device is requiredThis ensures developers have accurate expectations about the performance and behavior of
FlushAsync()
versusFlush(true)
.Fixes #11433.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.