Fix handle leak #36184
Merged
Fix handle leak #36184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, based on Copilot implementation from #36176. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a handle leak issue by ensuring that a database handle is properly released when the SqliteConnectionInternal constructor fails during password decryption.
- Adds a new test to verify that a failed constructor call releases its handle.
- Wraps the critical initialization code in a try–catch block and disposes the handle if an exception is thrown.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs | Adds test case for ensuring handle release on constructor failure |
| src/Microsoft.Data.Sqlite.Core/SqliteConnectionInternal.cs | Implements try–catch to dispose the handle in case of constructor failure |
AndriySvyryd
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35010