Extensions: adjust logic related to primary ctor parameter #79056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Extension Everything
jcouv
force-pushed
the
extensions-primaryctor
branch
from
9ca772e to
a0163cf
Compare
jcouv
commented
Jun 19, 2025
| @@ -1511,62 +1469,138 @@ private BoundMethodOrPropertyGroup ConstructBoundMemberGroupAndReportOmittedType | |||
| } | |||
| } | |||
|
|
|||
| private bool IsPossiblyCapturingPrimaryConstructorParameterReference(BoundExpression colorColorValueReceiver, out ParameterSymbol parameterSymbol) | |||
| private BoundExpression CheckAmbiguousPrimaryConstructorParameterAsColorColorReceiver(BoundExpression receiver, string plainName, ImmutableArray<TypeWithAnnotations> typeArguments, bool invoked, ArrayBuilder<Symbol> members, BindingDiagnosticBag diagnostics) | |||
There was a problem hiding this comment.
📝 extracted the logic and moved the check out of ConstructBoundMemberGroupAndReportOmittedTypeArguments (the caller is responsible to call CheckAmbiguousPrimaryConstructorParameterAsColorColorReceiver)
jcouv
force-pushed
the
extensions-primaryctor
branch
from
a0163cf to
bda2d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses parts of #78968
Relates to test plan #76130