-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Implement SVE2 AbsoluteDifferenceWidening(Upper/Lower) #116268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SVE2 AbsoluteDifferenceWidening(Upper/Lower) #116268
Conversation
Change-Id: Icac84e1e730993dbbcafe186b4e597c8536d4e58
Change-Id: Ide6440ac0753e046ca47ad77769a179996cb1809
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Change-Id: Idd85d335a9e46b002728699725bd1b4316e6f7fe
TestLibrary.TestFramework.BeginScenario("ConditionalSelect_Op2_all - operation in TrueValue"); | ||
ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}>.AllBitsSet, _fld1, _fld2, _fld2); | ||
ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}>.AllBitsSet, _fld1, _fld2, _fld2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that if there is anything wrong in this file, we would have got compilation errors, but what was the motivation of changing it? I don't see you are using this file anyways. Was it changed earlier thinking that you can reuse this file, but later found blockers because of which you had to create a new file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that if there is anything wrong in this file, we would have got compilation errors, but what was the motivation of changing it? I don't see you are using this file anyways. Was it changed earlier thinking that you can reuse this file, but later found blockers because of which you had to create a new file?
That was a request from me. The new file was mostly a copy/paste from the old file with those fixes and some other changes. Thought it made sense to put the fixes in the original file while in the area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@a74nh @kunalspathak
Contributing towards #115479