Skip to content

Implement SVE2 AbsoluteDifferenceWidening(Upper/Lower) #116268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

jacob-crawley
Copy link
Contributor

@a74nh @kunalspathak

Contributing towards #115479

Change-Id: Icac84e1e730993dbbcafe186b4e597c8536d4e58
Change-Id: Ide6440ac0753e046ca47ad77769a179996cb1809
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 3, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Change-Id: Idd85d335a9e46b002728699725bd1b4316e6f7fe
TestLibrary.TestFramework.BeginScenario("ConditionalSelect_Op2_all - operation in TrueValue");
ConditionalSelectScenario_TrueValue({Op1VectorType}<{Op1BaseType}>.AllBitsSet, _fld1, _fld2, _fld2);
ConditionalSelectScenario_TrueValue({RetVectorType}<{RetBaseType}>.AllBitsSet, _fld1, _fld2, _fld2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that if there is anything wrong in this file, we would have got compilation errors, but what was the motivation of changing it? I don't see you are using this file anyways. Was it changed earlier thinking that you can reuse this file, but later found blockers because of which you had to create a new file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that if there is anything wrong in this file, we would have got compilation errors, but what was the motivation of changing it? I don't see you are using this file anyways. Was it changed earlier thinking that you can reuse this file, but later found blockers because of which you had to create a new file?

That was a request from me. The new file was mostly a copy/paste from the old file with those fixes and some other changes. Thought it made sense to put the fixes in the original file while in the area.

@kunalspathak kunalspathak added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 6, 2025
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 1cda0cd into dotnet:main Jun 6, 2025
157 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants