-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Enable ML-DSA on Windows #116291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PranavSenthilnathan
merged 5 commits into
dotnet:main
from
PranavSenthilnathan:mldsa-bcrypt
Jun 5, 2025
Merged
Enable ML-DSA on Windows #116291
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
20b4e85
ML-DSA BCrypt
PranavSenthilnathan 36f926d
fix build error in CertificateAuthority
PranavSenthilnathan fd3da7c
Fix static initializer throwing
PranavSenthilnathan 9284e7c
PR feedback
PranavSenthilnathan 6bd053e
Refactor key export and fix struct layout
PranavSenthilnathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/libraries/Common/src/Interop/Windows/BCrypt/Interop.BCryptSetProperty.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics; | ||
using System.Runtime.InteropServices; | ||
|
||
using Microsoft.Win32.SafeHandles; | ||
|
||
internal static partial class Interop | ||
{ | ||
internal static partial class BCrypt | ||
{ | ||
[LibraryImport(Libraries.BCrypt, StringMarshalling = StringMarshalling.Utf16)] | ||
internal static unsafe partial NTSTATUS BCryptSetProperty( | ||
SafeBCryptHandle hObject, | ||
string pszProperty, | ||
void* pbInput, | ||
uint cbInput, | ||
uint dwFlags); | ||
|
||
internal static unsafe void BCryptSetSZProperty(SafeBCryptHandle hObject, string pszProperty, string pszValue) | ||
{ | ||
Debug.Assert(pszValue is not null); | ||
|
||
fixed (void* pbInput = pszValue) | ||
{ | ||
NTSTATUS status = BCryptSetProperty( | ||
hObject, | ||
pszProperty, | ||
pbInput, | ||
checked(((uint)pszValue.Length + 1) * 2), | ||
0); | ||
|
||
if (status != NTSTATUS.STATUS_SUCCESS) | ||
{ | ||
throw CreateCryptographicException(status); | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the helper, I think, but once we're adding it we should use it. So as a followup to this PR we should delete the
public static partial NTSTATUS BCryptSetProperty(SafeAlgorithmHandle hObject, string pszProperty, string pbInput, int cbInput, int dwFlags);
import in Interop\Windows\BCrypt\Cng.cs, and change all the callers of that to use this.