Skip to content

Remove dead code for parsing/emitting X86 instructions #116292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 6, 2025

Conversation

filipnavara
Copy link
Member

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

There are a bit more dead patterns: #103533 (comment)

A little portion of dead code accessing ESP+offset is not removed in stublinkerx86.

Can we figure out what are alive now?

@filipnavara
Copy link
Member Author

I removed bulk of the code in #115339 and now I checked every remaining method if it's used or not.

@filipnavara
Copy link
Member Author

On second look I found more things to remove. We can likely remove the single usage of X86EmitNearJump too and that will make another big chunk go away.

@filipnavara filipnavara requested a review from jkotas June 5, 2025 06:19
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 259204a into dotnet:main Jun 6, 2025
94 of 96 checks passed
@filipnavara filipnavara deleted the x86-dead-code branch June 6, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants