-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[browser] Bundler friendly output #116300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
pavelsavara
reviewed
Jun 11, 2025
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs
Show resolved
Hide resolved
akoeplinger
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment that should be addressed but LGTM otherwise
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ilonatommy
approved these changes
Jun 13, 2025
/ba-g Failures are not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleExports
instead of link to file as wellWasmBundlerFriendlyBootConfig
which enables to generate boot config, this is not working in browsers on it's own, but can be preprocessed by transpilers like babel. Using rollup or webpack it can be configured to (for example):WasmBundlerFriendlyBootConfig=true
& repacking the publish output with rollupmain.js
) aren't copied to the build output and so they can't be easily bundled into single filenpm
installed into helix machines/docker imagesnpm
path resolution will be fixed in a follow-upSample boot config
Contributes to #77191
Fixes #86162