Skip to content

Add CollectionsMarshal.AsBytes(BitArray) #116308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

stephentoub
Copy link
Member

This entailed:

  • Moving BitArray to corelib
  • Inverting the endianness concerns so that the internal storage is always little endian
  • Avoiding duplication of endianness-related changes by consolidating / deduplicating a bunch of the implementation (in particular around the SIMD implementations of And/Or/Xor/Not).
  • As long as I was touching a bunch of the code, cleaning up some of the antiquated style aspects.

Still need to validate perf and likely fix some big endian issues.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member Author

/azp list

Copy link

CI/CD Pipelines for this repository:

@stephentoub
Copy link
Member Author

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub
Copy link
Member Author

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub
Copy link
Member Author

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Jun 5, 2025

runtime-community

This does not run tests on big endian machines (disabled due to security). Replacement is being worked on, but it is not online yet.

I see that https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-community.yml#L47 is a misleading comment - it does just a build, it does not run any tests. Could you please fix it while you are on it?

@stephentoub stephentoub marked this pull request as ready for review June 9, 2025 17:44
@stephentoub stephentoub requested a review from tannergooding June 9, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants