[RuntimeAsync] Adding a simple test for reflection with async methods. #116329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a simple test for reflection with async methods and includes changes to project files and build configurations for testing runtime async functionality.
- A new test project and source file (reflectionSimple.csproj and reflectionSimple.cs) have been added to verify async reflection behavior.
- The Directory.Build.targets file has been updated to comment out the project build disable, and FEATURE_RUNTIME_ASYNC is now enabled in clrdefinitions.cmake.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/async/reflection/reflectionSimple.csproj | New project file for the async reflection test setup. |
| src/tests/async/reflection/reflectionSimple.cs | New test code exercising async reflection method invocations. |
| src/tests/async/Directory.Build.targets | Build targets updated to uncomment project building. |
| src/coreclr/clrdefinitions.cmake | Runtime async feature enabled via compile definitions. |
Comments suppressed due to low confidence (1)
src/coreclr/clrdefinitions.cmake:155
- The PR description indicates that the commit enabling runtime async should be undone, yet this change enables FEATURE_RUNTIME_ASYNC. Please clarify or revert this modification to ensure alignment with the PR purpose.
add_compile_definitions(FEATURE_RUNTIME_ASYNC)
|
Tagging subscribers to this area: @mangod9 |
jakobbotsch
approved these changes
Jun 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #115258
TODO: undo the commit that enables runtime async.