dotnet test for MTP #49647
Draft
dotnet test for MTP #49647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jul 3, 2025
|
|
||
| <Target Name="_MTPBuild" DependsOnTargets="_ComputeTargetFrameworkItems"> | ||
| <!-- This target is called by dotnet test for MTP for projects that are multi-targeted (using multiple target frameworks) --> | ||
| <Target Name="_MTPTest"> |
There was a problem hiding this comment.
NOTE: We should be careful to not regress TestTfmsInParallel. So maybe this outer _MTPTest target should also communicate back the TestTfmsInParallel value to the logger.
Youssef1313
commented
Jul 4, 2025
| @@ -17,7 +17,10 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <VSTestTargets Condition="'$(VSTestTargets)'==''">$(MSBuildExtensionsPath)\Microsoft.TestPlatform.targets</VSTestTargets> | |||
| </PropertyGroup> | |||
| <Import Condition="Exists('$(VSTestTargets)')" Project="$(VSTestTargets)" /> | |||
| <Target Name="_MTPBuild"> | |||
| <CallTarget Targets="Build" /> | |||
| <Target Name="_MTPTest" DependsOnTargets="ComputeRunArguments" Returns="@(_MTPTestInformation)"> | |||
There was a problem hiding this comment.
This target should do <CallTarget Targets="Build" Condition="'$(MTPNoBuild)'!='true'" />
Youssef1313
commented
Jul 4, 2025
Comment on lines
+106
to
+107
| <InnerTargets Condition="'$(MTPNoBuild)'!='true'">Build;_MTPTest</InnerTargets> | ||
| <InnerTargets Condition="'$(MTPNoBuild)'=='true'">_MTPTest</InnerTargets> |
There was a problem hiding this comment.
Note: this doesn't really work because CallTarget below is executed in a different scope and can't see the values set here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @KirillOsenkov as FYI, or if you have any comments. This is still very far from being completed.