Add code coverage for ImageListConverter & RelatedImageListAttribute

[Zheng-Li01]

Related #13442

Proposed changes
Add unit test file: ImageListConverterTests.cs & RelatedImageListAttributeTests for public/Internal methods of the ImageListConverter.cs & RelatedImageListAttribute.cs

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60416%. Comparing base (5821493) to head (1063a77).
Report is 85 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                  @@
##                main      #13511          +/-   ##
====================================================
+ Coverage   62.21083%   76.60416%   +14.39332%     
====================================================
  Files           3213        3238          +25     
  Lines         638302      639353        +1051     
  Branches       47201       47314         +113     
====================================================
+ Hits          397093      489771       +92678     
+ Misses        234153      146058       -88095     
+ Partials        7056        3524        -3532     

Flag	Coverage Δ
Debug	76.60416% <100.00000%> (+14.39332%)	⬆️
integration	18.54667% <ø> (-0.24212%)	⬇️
production	51.01313% <ø> (+32.22435%)	⬆️
test	97.40075% <100.00000%> (-0.00337%)	⬇️
unit	48.40215% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

Adds unit tests to improve code coverage for ImageListConverter and RelatedImageListAttribute.

• Introduce RelatedImageListAttributeTests covering constructor behavior
• Introduce ImageListConverterTests covering base type assignment and GetPropertiesSupported

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/test/unit/System.Windows.Forms/System/Windows/Forms/RelatedImageListAttributeTests.cs	Add test verifying that constructor value is returned by RelatedImageList property
src/test/unit/System.Windows.Forms/System/Windows/Forms/ImageListConverterTests.cs	Add tests for default constructor base type and GetPropertiesSupported

Comments suppressed due to low confidence (4)

src/test/unit/System.Windows.Forms/System/Windows/Forms/RelatedImageListAttributeTests.cs:4

• Test namespace 'System.Windows.Forms.Controls.Tests' does not align with the project’s folder and other test namespaces. Consider using 'System.Windows.Forms.Tests' to match existing patterns.

namespace System.Windows.Forms.Controls.Tests;

src/test/unit/System.Windows.Forms/System/Windows/Forms/RelatedImageListAttributeTests.cs:14

• Consider adding tests for Equals, GetHashCode, and default attribute behavior to cover the full RelatedImageListAttribute API surface.

RelatedImageListAttribute attr = new(value);

src/test/unit/System.Windows.Forms/System/Windows/Forms/ImageListConverterTests.cs:6

• Test namespace 'System.Windows.Forms.Controls.Tests' should be updated to 'System.Windows.Forms.Tests' to align with the assembly under test.

namespace System.Windows.Forms.Controls.Tests;

src/test/unit/System.Windows.Forms/System/Windows/Forms/ImageListConverterTests.cs:21

• Add tests for GetProperties, ConvertTo, and ConvertFrom methods of ImageListConverter to ensure functionality beyond support flags is covered.

Converter.GetPropertiesSupported(null).Should().BeTrue();

[ricardobossan]

Other than small comments, all LGTM!

[ricardobossan]

Thank you!