Skip to content

fix #13539 Unable to select ToolStripMenuItem and TooStripTextBox of MenuStrip2 in DemoConsole application #13546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jun 3, 2025

Fixes #13539

Root cause

There is a UserControl in the designer, which is big enough to cover the MenuStrip.

Issue_13539_2

Proposed changes

  • Make enough room for MenuStrip

Customer Impact

  • low

Screenshots

Before

cannot.select.mp4

After

Issue_13539_1

Test methodology

  • manual
Microsoft Reviewers: Open in CodeFlow

…of MenuStrip2 in DemoConsole application
@Epica3055 Epica3055 requested a review from a team as a code owner June 3, 2025 06:21
@Epica3055 Epica3055 changed the title Fix issues13539 fix #13539 Unable select ToolStripMenuItem and TooStripTextBox of MenuStrip2 in DemoConsole application Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60060%. Comparing base (9a17505) to head (2dc9a4c).
Report is 17 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13546         +/-   ##
===================================================
+ Coverage   76.59478%   76.60060%   +0.00581%     
===================================================
  Files           3230        3230                 
  Lines         639165      639149         -16     
  Branches       47297       47295          -2     
===================================================
+ Hits          489567      489592         +25     
+ Misses        146015      145990         -25     
+ Partials        3583        3567         -16     
Flag Coverage Δ
Debug 76.60060% <ø> (+0.00581%) ⬆️
integration 18.79761% <ø> (+0.01050%) ⬆️
production 51.00875% <ø> (+0.01156%) ⬆️
test 97.40411% <ø> (ø)
unit 48.37958% <ø> (-0.01440%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan
Copy link
Member

All LGTM!

@LeafShi1 LeafShi1 requested a review from Copilot June 4, 2025 00:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #13539 where the MenuStrip was being obstructed by a UserControl in the DemoConsole application.

  • The UserControl is now instantiated with explicit dimensions (350, 100) instead of filling the container.
  • The panel's starting height has been reduced from half of tabPage6's height to a third, likely to better accommodate the MenuStrip.

@KlausLoeffelmann KlausLoeffelmann changed the title fix #13539 Unable select ToolStripMenuItem and TooStripTextBox of MenuStrip2 in DemoConsole application fix #13539 Unable to select ToolStripMenuItem and TooStripTextBox of MenuStrip2 in DemoConsole application Jun 9, 2025
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Epica3055 Epica3055 merged commit 640b9a0 into dotnet:main Jun 10, 2025
9 checks passed
@MelonWang1 MelonWang1 added this to the 10 Preview6 milestone Jun 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable select ToolStripMenuItem and TooStripTextBox of MenuStrip2 in DemoConsole application
5 participants