Skip to content

chore: fix wrong JSDoc tag #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Jun 20, 2025

Prerequisites checklist

What is the purpose of this pull request?

Edited:

In this PR, I've fixed wrong JSDoc directive.

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

@@ -1,5 +1,5 @@
/**
* @filedescription The CSSLanguage class.
* @fileoverview The CSSLanguage class.
Copy link
Member Author

@lumirlumir lumirlumir Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @fileoverview The CSSLanguage class.
* @fileoverview The CSSLanguage class.

I've found that @filedescription is not a valid JSDoc directive.

https://jsdoc.app/tags-file

image

@lumirlumir lumirlumir marked this pull request as draft June 20, 2025 10:31
@lumirlumir lumirlumir changed the title test: replace strictEqual with deepStrictEqual for better accuracy test: add deepStrictEqual test for better accuracy Jun 20, 2025
@lumirlumir lumirlumir changed the title test: add deepStrictEqual test for better accuracy test: add deepStrictEqual tests for better accuracy Jun 20, 2025
@lumirlumir lumirlumir marked this pull request as ready for review June 20, 2025 13:48
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Jun 20, 2025
@lumirlumir lumirlumir marked this pull request as draft June 21, 2025 08:14
@lumirlumir lumirlumir force-pushed the test-replace-strictequal-with-deepstrictequal-for-better-accuracy branch from 8473e03 to 7a2cb1f Compare June 21, 2025 14:14
@lumirlumir lumirlumir changed the title test: add deepStrictEqual tests for better accuracy chore: fix wrong JSDoc directive Jun 21, 2025
@lumirlumir
Copy link
Member Author

Based on the feedback provided, I’ve removed the deepStrictEqual test and retained only the fix for the incorrect JSDoc directive.

@lumirlumir lumirlumir marked this pull request as ready for review June 21, 2025 14:17
@mdjermanovic mdjermanovic changed the title chore: fix wrong JSDoc directive chore: fix wrong JSDoc tag Jun 21, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 211bf21 into main Jun 21, 2025
22 checks passed
@mdjermanovic mdjermanovic deleted the test-replace-strictequal-with-deepstrictequal-for-better-accuracy branch June 21, 2025 14:42
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants