feat: add support for custom name parameter to includeIgnoreFile
#211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nzakas
previously approved these changes
May 27, 2025
There was a problem hiding this comment.
LGTM. Would like @mdjermanovic to review before merging.
Just a note: When adding public-facing functionality, it's better to open an issue first to gather feedback before sending a PR. That way, we can make sure the team is aligned before moving on to implementation.
…ttps://github.com/eslint/rewrite into feat-add-custom-name-param-to-include-ignore-file
|
@nzakas I'll keep that in mind! @mdjermanovic I've added a new commit 80cf734! |
1 task
mdjermanovic
previously approved these changes
May 29, 2025
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas to verify the latest changes.
nzakas
reviewed
May 30, 2025
mdjermanovic
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas to verify latest changes.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
Currently, the
globalIgnores()helper function supports a customnameproperty in its config object.However, the
includeIgnoreFile()helper function, which has similar behavior toglobalIgnores(), does not support a custom name for its config object. This prevents users from using a custom name in that context.So, in this PR, I've added support for a custom
nameparameter toincludeIgnoreFile().I've also added tests and missing JSDoc type hints to
globalIgnores().What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?