Skip to content

pdptool - use the correct params name for create-proof-set command #507

Open
@longfeiWan9

Description

@longfeiWan9

Checklist

  • This is not a question or a support request. If you have any Curio related questions, please ask in the discussion forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release candidate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.

Curio component

  • PoRep Pipeline
  • Snap Deals
  • Market
  • IPNI provider
  • Curio UI
  • Other

Improvement Suggestion

When I use pdptool to create a proofset, the command line suggests that I must provide --recordkeeper which is not mentioned anywhere in the pdp repo. So I guess it must be the smart contract address for either PDP Verifier or PDP service.

To avoid confusion, I suggest we change the recordKeeper to pdp-service-contract for a better user experience. For example:

NAME:
   pdptool create-proof-set - Create a new proof set on the PDP service

USAGE:
   pdptool create-proof-set [command options]

OPTIONS:
   --service-url value   URL of the PDP service
   --pdp-service-contract value  Address of the pdp service contract
   --service-name value  Service Name to include in the JWT token
   --extra-data value    Optional ABI-encoded extra data as a hex string to pass to the listener contract (max 2048 bytes)
   --help, -h            show help

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions