-
Notifications
You must be signed in to change notification settings - Fork 24
chore(pdp): add more logging; don't bail early on tx error #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"error", err, | ||
"errorType", fmt.Sprintf("%T", err)) | ||
// Continue processing other transactions instead of returning | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm suspecting that the change here from a return
to a continue
might be part of the issue - if we return while we have a tx that gives us something other than ethereum.NotFound
early in the list, then the remainder won't be checked
This cleared up the queue on our test server, but I'm not sure if it was the restart that did it or the changes here. But I think this is useful, it gives much more insight in the logs to PDP interactions and tx processing. |
Parking this as a draft for now, trying to figure out #548