Skip to content

chore(pdp): add more logging; don't bail early on tx error #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 24, 2025

Parking this as a draft for now, trying to figure out #548

@rvagg rvagg force-pushed the rvagg/txlogging branch from 70460ab to c78da4f Compare June 24, 2025 06:11
"error", err,
"errorType", fmt.Sprintf("%T", err))
// Continue processing other transactions instead of returning
continue
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspecting that the change here from a return to a continue might be part of the issue - if we return while we have a tx that gives us something other than ethereum.NotFound early in the list, then the remainder won't be checked

@rvagg rvagg changed the title chore(pdp): add transaction processing logging (DRAFT) chore(pdp): add more logging; don't bail early on tx error Jun 24, 2025
@rvagg rvagg marked this pull request as ready for review June 24, 2025 06:27
@rvagg
Copy link
Member Author

rvagg commented Jun 24, 2025

This cleared up the queue on our test server, but I'm not sure if it was the restart that did it or the changes here. But I think this is useful, it gives much more insight in the logs to PDP interactions and tx processing.

@ZenGround0 ZenGround0 merged commit 289b2db into filecoin-project:synapse Jun 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants