chore: update go-multiaddr to v0.15 #12912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/go-multiaddr-v015
branch
from
6988a33 to
4a74a69
Compare
10 tasks
MarcoPolo
force-pushed
the
marco/go-multiaddr-v015
branch
from
4a74a69 to
fbb8617
Compare
MarcoPolo
force-pushed
the
marco/go-multiaddr-v015
branch
from
3b1b07a to
75adfbc
Compare
4 tasks
|
Closing this as outdated - we have bumped go-multiaddrs to v0.15 in: #13173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the go-multiaddr dependency and this Lotus' usage of go-multiaddr. Rationale for this breaking change can be found in the draft release notes of go-multiaddr: https://github.com/multiformats/go-multiaddr/releases/. But the tl;dr is that this breaking change gets us away from the easy-to-misuse Mutliaddr interface that has led to many nil-ptr panics.
Another important thing to note:
You'll likely need this patch libp2p/go-libp2p-kad-dht#1046 backported to whatever go-libp2p-kad-dht version you're on if you don't want to update that dependency. Currently this branch points to a commit that is Lotus's current version of kad-dht (v0.25.2) plus that patch.
Requires: