[GHSA-jc7r-v6fg-2gpf] Apache CXF TLS hostname verification does not work correctly with com.sun.net.ssl.* #5669
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The code for the vulnerability is contained within the cxf-rt-transports-http package.
The commit for the fix is here apache/cxf@fae6fab which shows code changes within the /rt/transports/http directory. That directory contains a pom.xml (https://github.com/apache/cxf/blob/fae6fabf9bd7647f5e9cb68897a7d72b545b741b/rt/transports/http/pom.xml) file with an artifactId of "cxf-rt-transports-http".
https://repo1.maven.org/maven2/org/apache/cxf/cxf/3.2.7/ shows that the "org.apache.cxf:cxf" package does not contain any binary files and https://repo1.maven.org/maven2/org/apache/cxf/cxf/3.2.7/cxf-3.2.7.pom shows pom - it's a Maven POM file only and not binary code.
For that reason, I've left "org.apache.cxf:apache-cxf" as a vulnerable dependency (likely a 'bundle' package) but replaced "org.apache.cxf:cxf" with "org.apache.cxf:cxf-rt-transports-http".
Our application had a "false negative" where the vulnerability wasn't showing up - we directly depended on cxf-rt-transports-http and weren't using the bundled distribution package.