Patch Octokit indirect dependency with pinned commit to Probot GitHub repository #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR patches an indirect dependency by pinning the Azure Functions adapter to a specific GitHub commit and updates the Probot dev dependency to the latest major version.
- Pin
@probot/adapter-azure-functionsto the patched commit in the Probot repo - Bump
probotdevDependency from v12 to v13 for compatibility with newer features
Comments suppressed due to low confidence (2)
package.json:15
- Pinning to a specific GitHub commit can introduce fragility and make future updates harder. Consider using a patch mechanism (e.g., npm resolutions or patch-package) and documenting the rationale in the repo’s README or a comment.
"@probot/adapter-azure-functions": "github:probot/adapter-azure-functions#4a0f805a7916c07e6dd9d7f1c29e1e75ea72d190"
package.json:26
- Upgrading Probot from v12 to v13 may introduce breaking changes. Verify compatibility in your codebase, update any v12-specific patterns, and add or adjust integration tests to cover the new Probot behaviors.
"probot": "^13.4.5"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream npm package
@probot/adapter-azure-functionhas not published a patched release, but the tied GitHub repo is patched.Hardcode a reference to the latest commit to take advantage of the unreleased patched version.