Move organization's visibility change to danger zone. #34814
Conversation
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
GiteaBot
added
lgtm/need 1
…nto lunny/refactor_org_setting
web_src/js/features/org-settings.ts
Outdated
| @@ -0,0 +1,25 @@ | |||
| function initOrgVisibilityChange() { | |||
There was a problem hiding this comment.
Can we avoid introducing this kind of JS code?
Do you mean that in the future we need to introduce JS code for almost every form or modal?
There was a problem hiding this comment.
I’ve identified the issue as well. It seems we need to use inline JavaScript unless we refactor the modal using a Vue template. Do you have any suggestions on how we might handle this more cleanly?
There was a problem hiding this comment.
Refactor the "areYouSure dirty-form check" code first, only allow changed (dirty) form to submit.
There was a problem hiding this comment.
OK. I revert the related change to allow another PR do it from a framework layer. ecc5b72
options/locale/locale_en-US.ini
Outdated
| settings.change_visibility_notices_1 = This operation <strong>CANNOT</strong> be undone. | ||
| settings.change_visibility_notices_2 = Non-members will lose access to the organization’s repositories if visibility is changed to private. | ||
| settings.change_visibility_no_change = You did not make any changes to visibility. | ||
| settings.change_visibility_failed = Failed to change the visibility of %s due to an internal error. |
There was a problem hiding this comment.
In the future, we need to introduce various "failed ... due to an internal error" messages for every route handler?
There was a problem hiding this comment.
Even we have a common sentence like Failed to xxx due to an internal error, we still have to translate change the visibility of %s? So that it's difficult to reuse these sentences.
There was a problem hiding this comment.
Why such message is needed?
"Internal error" should never (seldom) happen to users, even they see the message, the message helps nothing and they can do nothing.
options/locale/locale_en-US.ini
Outdated
| @@ -2840,6 +2840,14 @@ settings.location = Location | |||
| settings.permission = Permissions | |||
| settings.repoadminchangeteam = Repository admin can add and remove access for teams | |||
| settings.visibility = Visibility | |||
| settings.change_visibility = Change Visibility | |||
| settings.invalid_visibility = The new visibility is not valid. | |||
| settings.change_visibility_notices_1 = This operation <strong>CANNOT</strong> be undone. | |||
There was a problem hiding this comment.
Are there really any destructive operations in some cases that cannot be undone?
There was a problem hiding this comment.
Yes, all repository stars will be removed when an organization is converted to private. This behavior follows the logic introduced in #11717. Please note that these stars cannot be restored even if the organization is later changed back to public.
There was a problem hiding this comment.
Maybe this should be somehow more detailed because otherwise it looks like visibility change is final and visibility cannot be changed anymore
Uh oh!
There was an error while loading. Please reload this page.