Greater control over RBAC objects and rules #3869
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
force-pushed
the
petewall/helm-with-namespaced-rbac
branch
from
f1df113 to
e4a491e
Compare
…ange. Co-authored-by: @kun98-liu Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
changed the title
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This change allows for the RBAC object creation to create namespaced-Role and RoleBinding objects instead of ClusterRoles and ClusterRoleBindings.
It also allows for the specific rules attached to the Roles/ClusterRoles to be modified.
Which issue(s) this PR fixes
Fixes #196
Fixes #3839
Fixes #2224
Fixes #681
Notes to the Reviewer
PR Checklist