Skip to content

Update alerting from 3e20fda3b872 to dc5663fe02aa #11797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

alexander-akhmetov
Copy link
Contributor

@alexander-akhmetov alexander-akhmetov commented Jun 20, 2025

What this PR does

Update grafana/alerting and grafana/prometheus-alertmanager modules.

grafana/alerting diff:

grafana/prometheus-alertmanager diff:

The main change is the change of WebhookConfig.Timeout type from time.Duration to model.Duration to make marshalling to JSON and YAML the same. It does not affect YAML marshalling, only JSON and is needed for Grafana so in the future it can start sending JSON encoded configurations with alertmanager receivers. More details are in grafana/prometheus-alertmanager#117

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

@alexander-akhmetov alexander-akhmetov added component/alertmanager changelog-not-needed PRs that don't need a CHANGELOG.md entry labels Jun 20, 2025
@alexander-akhmetov alexander-akhmetov force-pushed the alexander-akhmetov/upgrde-alerting branch from 931e2e8 to b9ee777 Compare June 20, 2025 11:57
@alexander-akhmetov alexander-akhmetov marked this pull request as ready for review June 20, 2025 13:40
@alexander-akhmetov alexander-akhmetov requested review from a team and stevesg as code owners June 20, 2025 13:40
@alexander-akhmetov alexander-akhmetov marked this pull request as draft June 20, 2025 13:40
@alexander-akhmetov alexander-akhmetov marked this pull request as ready for review June 20, 2025 13:40
@alexander-akhmetov alexander-akhmetov marked this pull request as draft June 24, 2025 09:22
@alexander-akhmetov alexander-akhmetov changed the title Update alerting from 3e20fda3b872 to 863b09716e60 Update alerting from 3e20fda3b872 to dc5663fe02aa Jun 27, 2025
@alexander-akhmetov alexander-akhmetov force-pushed the alexander-akhmetov/upgrde-alerting branch from b9ee777 to 5815a9c Compare June 27, 2025 09:44
@alexander-akhmetov alexander-akhmetov force-pushed the alexander-akhmetov/upgrde-alerting branch from 5815a9c to 751b160 Compare June 27, 2025 09:46
@alexander-akhmetov alexander-akhmetov marked this pull request as ready for review June 27, 2025 10:03
@stevesg stevesg merged commit 7f51727 into main Jun 27, 2025
31 checks passed
@stevesg stevesg deleted the alexander-akhmetov/upgrde-alerting branch June 27, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-not-needed PRs that don't need a CHANGELOG.md entry component/alertmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants