Skip to content

actions: automatically close existing mimir-prometheus vendoring PRs #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

actions: automatically close existing mimir-prometheus vendoring PRs #11840

merged 1 commit into from
Jun 25, 2025
+17 −0

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jun 24, 2025 •
edited
Loading

Why

This prevents accumulation of stale vendoring PRs targeting the same branch, which can clutter the PR list and cause confusion about which vendoring update is current.

How

Copies the approach from an internal repo to automatically close existing vendoring PRs when new ones are created.

  • Added PR closure logic after the create-pull-request step
  • Uses same approach as backend-enterprise: search for existing PRs with the vendoring label, comment on them explaining supersession, then close with branch deletion
  • Skips the current PR being created to avoid self-closure

@dimitarvdimitrov
Add automatic closure of existing Mimir-Prometheus vendoring PRs
bc11ece 
Copy the approach from backend-enterprise to automatically close existing
vendoring PRs when new ones are created. This prevents accumulation of
stale vendoring PRs targeting the same branch.
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner June 24, 2025 15:29
@dimitarvdimitrov dimitarvdimitrov added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Jun 24, 2025
aknuds1
aknuds1 approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICT.

@aknuds1 aknuds1 requested a review from Copilot June 24, 2025 15:32
Copilot
Copilot AI reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dimitarvdimitrov dimitarvdimitrov merged commit bcb8b31 into main Jun 25, 2025
32 of 33 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/actions/close-existing-vendoring-prs branch June 25, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@aknuds1 aknuds1 aknuds1 approved these changes

Assignees
No one assigned
Labels
changelog-not-needed PRs that don't need a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitarvdimitrov @aknuds1