fix: doc-explorer search combobox null checks #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a null check to fix a bug in the doc explorer that happens when the search field loses focus when there is no text in the search input. To reproduce in the [Graphiql live demo](https://graphql.github.io/swapi-graphql/): - Open the browser console - Open the Documentation Explorer (upper left) - Start searching in the pane - Delete your search term and click away from the search bar - See the console log this error: `Uncaught TypeError: right-hand side of 'in' should be an object, got null` The cause: The headlessui combobox is nullable by default in ^2, a change in api from ^1 Our existing onChange handler does not expect null values to be passed The fix: Add an early null check to the onChange handler
🦋 Changeset detectedLatest commit: 6a8d630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dimaMachina
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a null check to fix a bug in the doc explorer that happens when the search field loses focus when there is no text in the search input. To reproduce in the Graphiql live demo:
Uncaught TypeError: right-hand side of 'in' should be an object, got nullThe cause:
The headlessui combobox is nullable by default in ^2, a change in api from ^1 Our existing onChange handler does not expect null values to be passed
The fix:
Add an early null check to the onChange handler