merge by name and social urls #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
hasparus
commented
Jun 17, 2025
| // we prefer the data from the most recent years | ||
| .sort((a, b) => Math.max(...a._years) - Math.max(...b._years)) | ||
| // and the `year` of the conference we're fetching data for | ||
| .concat([speaker]) |
There was a problem hiding this comment.
We merge speaker data starting from oldest to newest and then correct year. (So building 2025 site next year it will effectively Object.assign(s2023, s2024, s2025, s2026, s2025)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
saihaj
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the speakers sometimes have multiple user accounts in Sessionize (or Sched) and we can't expect the
usernameacross years will be the same, we now merge the speakers during site build (not during sync, during sync we just find equal full names but this is editable by a human, we never remove items from that list).