Skip to content

Conversation

@dsa0x
Copy link
Member

@dsa0x dsa0x commented May 28, 2025

Fixes #

Target Release

1.13.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x force-pushed the sams/list-genconfig branch from 0220cd9 to 5c3631d Compare May 28, 2025 11:26
@dsa0x dsa0x added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label May 28, 2025
@dsa0x dsa0x force-pushed the sams/list-genconfig branch 2 times, most recently from 9c45eda to 31abfb0 Compare May 28, 2025 11:27
@dsa0x dsa0x force-pushed the sams/tfquery-execute branch from 24d0a55 to 439cb9e Compare May 28, 2025 15:28
@dsa0x dsa0x force-pushed the sams/list-genconfig branch from 49d6d13 to b1fec46 Compare June 2, 2025 20:36
@dsa0x dsa0x marked this pull request as ready for review June 2, 2025 20:37
@dsa0x dsa0x requested a review from a team as a code owner June 2, 2025 20:37
@dsa0x dsa0x force-pushed the sams/tfquery-execute branch 6 times, most recently from 0d9f62d to b0a7c2e Compare June 10, 2025 15:56
Base automatically changed from sams/tfquery-execute to sams/list-result-schema June 10, 2025 17:38
Base automatically changed from sams/list-result-schema to main June 10, 2025 18:08
@dsa0x dsa0x force-pushed the sams/list-genconfig branch from b1fec46 to 8c12ea0 Compare June 11, 2025 14:54
@dsa0x dsa0x requested review from dbanck and jbardin June 12, 2025 12:22
@dsa0x dsa0x force-pushed the sams/list-genconfig branch from a4fd5e9 to 68a752e Compare June 16, 2025 17:34
Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, I'm sure we're going to be coming back to this code as we figure out how code generation interacts with the cloud UI. It would be good if we can find a way reduce any copying between the import generation and this though, so we can evolve them together.

@dbanck dbanck force-pushed the dbanck/tfquery-cli branch 3 times, most recently from 912b10f to 679b585 Compare June 30, 2025 09:56
@dsa0x dsa0x force-pushed the sams/list-genconfig branch 2 times, most recently from e331e73 to 052b03c Compare July 1, 2025 06:21
@dbanck dbanck force-pushed the dbanck/tfquery-cli branch from 679b585 to 2066ea6 Compare July 1, 2025 07:58
@dsa0x dsa0x force-pushed the sams/list-genconfig branch from 16dce47 to 8050ca1 Compare July 1, 2025 09:13
@dbanck dbanck force-pushed the dbanck/tfquery-cli branch from a270992 to e5bb256 Compare July 2, 2025 08:28
Base automatically changed from dbanck/tfquery-cli to main July 2, 2025 13:06
@dsa0x dsa0x requested a review from a team as a code owner July 2, 2025 13:10
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, but I encountered some issues while testing this.

I also wasn't able to have the config written to a file (when not using -json). Maybe we need to update the backends to write the config

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! LGTM!

I've pushed a small addition to write the configuration to disk

@dsa0x dsa0x merged commit 8d8b2bb into main Jul 4, 2025
8 checks passed
@dsa0x dsa0x deleted the sams/list-genconfig branch July 4, 2025 09:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants