-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Generate config for list results #37173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0220cd9 to
5c3631d
Compare
9c45eda to
31abfb0
Compare
24d0a55 to
439cb9e
Compare
49d6d13 to
b1fec46
Compare
0d9f62d to
b0a7c2e
Compare
b1fec46 to
8c12ea0
Compare
a4fd5e9 to
68a752e
Compare
jbardin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start, I'm sure we're going to be coming back to this code as we figure out how code generation interacts with the cloud UI. It would be good if we can find a way reduce any copying between the import generation and this though, so we can evolve them together.
68a752e to
4b2f4cb
Compare
912b10f to
679b585
Compare
e331e73 to
052b03c
Compare
679b585 to
2066ea6
Compare
16dce47 to
8050ca1
Compare
a270992 to
e5bb256
Compare
1ed8a7c to
fe3c957
Compare
dbanck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, but I encountered some issues while testing this.
I also wasn't able to have the config written to a file (when not using -json). Maybe we need to update the backends to write the config
dbanck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! LGTM!
I've pushed a small addition to write the configuration to disk
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #
Target Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry