feat(duckdb): don't translate ops.First() to ops.FirstValue() in windows #11308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
NickCrews
force-pushed
the
any-agg-in-window
branch
from
fc60c19 to
63a7981
Compare
|
Ah, I think the actual bug is that the order_by clause isn't properly transferred to the window Op from the First op. If you do |
|
Also there is a separate bug where we should be forwarding the |
Do not replace first() with first_value() because, per https://duckdb.org/docs/stable/sql/functions/window_functions#aggregate-window-functions The first and last aggregate functions are shadowed by the respective general-purpose window functions, with the minor consequence that the FILTER clause is not available for these but IGNORE NULLS is. After this change, the generated SQL is more canonical, and include_null actually works. This probably should wait until ibis-project#11311 lands, which has the tests for this change.
NickCrews
force-pushed
the
any-agg-in-window
branch
from
63a7981 to
0c393b5
Compare
|
marking as WIP until #11314 is resolved, because that is a better implementation. |
NickCrews
changed the title
t.group_by().mutate(x.first(order_by="y"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11307
Probably a bunch of other backends will fail this test, when I see which ones I'll add them.
Maybe I could solve this in a better way, but at least I get it working for duckdb here.