Skip to content

docs: enhance file upload limits documentation #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Jul 10, 2025

❤️ Thank you for your contribution!

Description

Updated the documentation for limiting file uploads to clarify
frontend and backend configurations.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I've created logical separate commits and followed the commit message format.
  • I've targeted the master branch.
  • If this documentation change impacts the current release of InvenioRDM, I will backport it to the production branch following approval or indicate to a maintainer that it should be backported.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 force-pushed the update-max-file-limit-docs branch from 1394b4f to c8a66e1 Compare July 11, 2025 10:17
Updated the documentation for limiting file uploads to clarify
frontend and backend configurations.
@Samk13 Samk13 force-pushed the update-max-file-limit-docs branch from c8a66e1 to 85e6ca3 Compare July 11, 2025 10:20
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement, and can be merged whenever you're ready.

```
## Limiting File Uploads

Limiting the maximum size for file uploads and number of files is critical to avoid abuse (e.g., filling up storage or uploading too many files).InvenioRDM already ships with sensible limits (10 GB per file and 10 GB total per bucket) that work for most deployments. Adjust these if your use case requires stricter or looser limits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a space after the first sentence.

RDM_MEDIA_FILES_DEFAULT_MAX_FILE_SIZE = 10 * 10**9
"""Max size per file 10 GB"""


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need the extra space. I might also put the Rest quotas up higher. I think the media files are completely separate, so most people won't have to set them.

@Samk13
Copy link
Member Author

Samk13 commented Jul 15, 2025

Thanks for the review @tmorrell . I had a DM with @mirekys on Discord, and he’ll be submitting a PR soon with updated and more detailed information on that.
We can close this once that PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants