-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP 4960: Container Stop Signals - Update for v1.34 #5400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP 4960: Container Stop Signals - Update for v1.34 #5400
Conversation
sreeram-venkitesh
commented
Jun 11, 2025
- One-line PR description: KEP update for KEP 4960: Container Stop Signals
- Issue link: Container Stop Signals #4960
- Other comments:
- We're doing an alpha2 in v1.34.
- This PR includes only changes to the proposal which were discussed after the KEP PR was merged last cycle.
- There are no new PRR updates.
sorry it's not totally clear to me what is being added in alpha2. both of the pieces added seem to have landed in alpha1. If there's no code changing in 1.34, I don't think we need to bump the milestone |
@haircommander: The only code change is adding the metrics which were mentioned in the PRR in alpha. |
can you add those metrics here and call them out in the KEP doc as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @mrunalp (official KEP approver from the kep.yaml) |
@haircommander I've added the metrics to kep.yaml. These were already mentioned in the KEP readme. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, SergeyKanzhelev, sreeram-venkitesh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |