Skip to content

KEP 4960: Container Stop Signals - Update for v1.34 #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sreeram-venkitesh
Copy link
Member

  • One-line PR description: KEP update for KEP 4960: Container Stop Signals
  • Other comments:
    • We're doing an alpha2 in v1.34.
    • This PR includes only changes to the proposal which were discussed after the KEP PR was merged last cycle.
    • There are no new PRR updates.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 June 11, 2025 08:14
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2025
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Jun 11, 2025
14 tasks
@haircommander
Copy link
Contributor

sorry it's not totally clear to me what is being added in alpha2. both of the pieces added seem to have landed in alpha1. If there's no code changing in 1.34, I don't think we need to bump the milestone

@sreeram-venkitesh
Copy link
Member Author

@haircommander: The only code change is adding the metrics which were mentioned in the PRR in alpha.

@haircommander
Copy link
Contributor

can you add those metrics here and call them out in the KEP doc as well?

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@SergeyKanzhelev
Copy link
Member

/assign @mrunalp

(official KEP approver from the kep.yaml)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@sreeram-venkitesh
Copy link
Member Author

can you add those metrics here and call them out in the KEP doc as well?

@haircommander I've added the metrics to kep.yaml. These were already mentioned in the KEP readme.

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, SergeyKanzhelev, sreeram-venkitesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1d4bb80 into kubernetes:master Jun 16, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants