[ja] re: Minor update for content/ja/docs/contribute/localization.md #51357

youmeim · 2025-06-23T14:51:42Z

Reopened PR, which is originated from #49695 .

Description

This PR contains a small modification on content/ja/docs/contribute/localization.md, which provides more clear translation workflow to support decisions by contributors.

Reviewed at once by @nasa9084 and @Okabe-Junya .
(Thanks for your kindly mention this, and sorry for bothering you!)

This PR is just related to Japanese localization, so Japanese comments or discussions are prefered/reccomended.

Issue

Closes: #49285

/area localization
/language ja

netlify · 2025-06-23T15:00:34Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`648585f`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/686359017549e40008fd7e61
😎 Deploy Preview	https://deploy-preview-51357--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

youmeim · 2025-06-23T15:03:49Z

とりあえず立てておきます。お手数をおかけして大変申し訳ありません。
最新の議論のチェック＆追随はできていませんが、できる範囲で見直しておきます。

preview: https://deploy-preview-51357--kubernetes-io-main-staging.netlify.app/ja/docs/contribute/localization/

このPRの概要はこちらで議論した通りのものです。
また、日本語ローカリゼーションガイドについて、以前の議論で挙がっていた修正内容が含まれています。

また、マージに関しては標準化用語集の翻訳が完遂されていることが望ましいとの指摘がありました。

from #49285 (comment)
標準化用語集( https://kubernetes.io/ja/docs/reference/glossary/?all=true ) に記載の用語は、その表現に準拠させる
ただしその場合は、 https://kubernetes.io/ja/docs/reference/glossary/?all=true の翻訳を完了させることがガイドライン更新の必要条件になると思います

レビューにご参考頂ければと思います。

Okabe-Junya

ありがとうございます、数点コメントさせていただきました

content/ja/docs/contribute/localization.md

Okabe-Junya · 2025-06-23T16:12:22Z

/cc t-inu

Okabe-Junya · 2025-06-23T16:12:45Z

/hold

nasa9084 · 2025-06-24T09:42:11Z

LGTM, other than okabe-san's comments, thank you~!

Okabe-Junya · 2025-06-24T16:08:21Z

/label tide/merge-method-squash

Okabe-Junya · 2025-06-24T16:08:42Z

#51357 (comment) の確認だけお願いします、それ以外はLGTMです

linux-foundation-easycla · 2025-06-25T14:22:31Z

The committers listed above are authorized under a signed CLA.

✅ login: youmeim / name: OneSazae (9fdeac6, 648585f, 8ad0d8a, 7486362, bf152b1)

youmeim · 2025-06-25T14:30:58Z

t-inu Okabe-Junya nasa9084 レビューありがとうございます。反映しました。#51357 (comment)

Okabe-Junya

ありがとうございます、nit commentを残しましたがLGTMです

/lgtm

content/ja/docs/contribute/localization.md

k8s-ci-robot · 2025-06-25T15:31:17Z

LGTM label has been added.

Git tree hash: 25ed2dcc748fe8dc0e17fa87d6ef55bbcfd0ac22

content/ja/docs/contribute/localization.md

t-inu

/lgtm

k8s-ci-robot · 2025-06-30T13:31:21Z

LGTM label has been added.

Git tree hash: 6dd39e550c48457a91f58a10a6c1a0639a9d5766

Okabe-Junya

@youmeim

repo全体でNetlifyのbuildに失敗する問題が発生していました。upstream/mainに修正が入って解消されたので、upstream/main でこのPRをrebaseしていただきたいです

/assign
/approve

k8s-ci-robot · 2025-06-30T17:55:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/ja/OWNERS~~ [Okabe-Junya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>

youmeim · 2025-07-01T03:50:56Z

@youmeim

repo全体でNetlifyのbuildに失敗する問題が発生していました。upstream/mainに修正が入って解消されたので、upstream/main でこのPRをrebaseしていただきたいです

/assign
/approve

@Okabe-Junya ありがとうございます。
対応しました。

今更ですが、自分のレビューコメントがpendingとなっていて、未ログイン時に自分自身のコメントが表示されないことに気づきました。
organizationのメンバーは見えているものと思っていますが、間違いないでしょうか。。。

レビュー頂いた際のレスポンスのうち、きちんと残した方が良いものについては、メインスレッドで議論した方が良さそうだなと思いました。

t-inu · 2025-07-01T04:05:53Z

Pending状態のコメントは、本人以外は誰からも見えないと思います。
Files changedの画面で、右上にあるReview changesから、Submit reviewボタンを押すことで公開されます。

youmeim · 2025-07-01T13:29:07Z

Pending状態のコメントは、本人以外は誰からも見えないと思います。 Files changedの画面で、右上にあるReview changesから、Submit reviewボタンを押すことで公開されます。

そうなのですね。
ということは、レビューに直接関連づけてコメントする際は、Conversation内ではなくFile changedタブ側で作業したほうが良さそうですね...

ご教示ありがとうございます。

t-inu

/lgtm
/unhold

k8s-ci-robot · 2025-07-01T13:57:49Z

LGTM label has been added.

Git tree hash: 5652f14427d154ccc344df0349bba53276286e7b

…ubernetes#51357) * [ja] modify content/ja/docs/contribute/localization.md * Apply suggestions from code review Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * apply suggestion from code review, fix protocol schema of links * Update content/ja/docs/contribute/localization.md Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * Update content/ja/docs/contribute/localization.md Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> --------- Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

k8s-ci-robot added area/localization language/ja sig/docs labels Jun 23, 2025

k8s-ci-robot requested review from b1gb4by and bells17 June 23, 2025 14:51

k8s-ci-robot added cncf-cla: yes size/S labels Jun 23, 2025

Okabe-Junya reviewed Jun 23, 2025

View reviewed changes

content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved

content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved

content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved

k8s-ci-robot requested a review from t-inu June 23, 2025 16:12

k8s-ci-robot added the do-not-merge/hold label Jun 23, 2025

k8s-ci-robot added the tide/merge-method-squash label Jun 24, 2025

k8s-ci-robot added cncf-cla: no and removed cncf-cla: yes labels Jun 25, 2025

youmeim force-pushed the 49285-modify-localization-guide-ja branch from 4c63e61 to 0d44ec6 Compare June 25, 2025 14:24

k8s-ci-robot added cncf-cla: yes and removed cncf-cla: no labels Jun 25, 2025

Okabe-Junya reviewed Jun 25, 2025

View reviewed changes

content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved

k8s-ci-robot assigned Okabe-Junya Jun 25, 2025

k8s-ci-robot added the lgtm label Jun 25, 2025

k8s-ci-robot removed the lgtm label Jun 27, 2025

k8s-ci-robot requested a review from Okabe-Junya June 27, 2025 14:40

t-inu reviewed Jun 28, 2025

View reviewed changes

content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved

t-inu reviewed Jun 30, 2025

View reviewed changes

k8s-ci-robot assigned t-inu Jun 30, 2025

k8s-ci-robot added the lgtm label Jun 30, 2025

Okabe-Junya reviewed Jun 30, 2025

View reviewed changes

k8s-ci-robot added the approved label Jun 30, 2025

youmeim and others added 5 commits July 1, 2025 12:39

[ja] modify content/ja/docs/contribute/localization.md

9fdeac6

Apply suggestions from code review

8ad0d8a

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

apply suggestion from code review, fix protocol schema of links

7486362

Update content/ja/docs/contribute/localization.md

bf152b1

Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

Update content/ja/docs/contribute/localization.md

648585f

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>

youmeim force-pushed the 49285-modify-localization-guide-ja branch from 977153a to 648585f Compare July 1, 2025 03:41

k8s-ci-robot removed the lgtm label Jul 1, 2025

k8s-ci-robot requested review from Okabe-Junya and t-inu July 1, 2025 03:41

t-inu reviewed Jul 1, 2025

View reviewed changes

k8s-ci-robot added lgtm and removed do-not-merge/hold labels Jul 1, 2025

k8s-ci-robot merged commit d790240 into kubernetes:main Jul 1, 2025
6 checks passed

[ja] re: Minor update for content/ja/docs/contribute/localization.md #51357

[ja] re: Minor update for content/ja/docs/contribute/localization.md #51357

Uh oh!

Conversation

youmeim commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Uh oh!

netlify bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

youmeim commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Okabe-Junya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Okabe-Junya commented Jun 23, 2025

Uh oh!

Okabe-Junya commented Jun 23, 2025

Uh oh!

nasa9084 commented Jun 24, 2025

Uh oh!

Okabe-Junya commented Jun 24, 2025

Uh oh!

Okabe-Junya commented Jun 24, 2025

Uh oh!

linux-foundation-easycla bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youmeim commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Okabe-Junya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 25, 2025

Uh oh!

Uh oh!

t-inu left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 30, 2025

Uh oh!

Okabe-Junya left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 30, 2025

Uh oh!

youmeim commented Jul 1, 2025

Uh oh!

t-inu commented Jul 1, 2025

Uh oh!

youmeim commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t-inu left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

youmeim commented Jun 23, 2025 •

edited

Loading

netlify bot commented Jun 23, 2025 •

edited

Loading

youmeim commented Jun 23, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jun 25, 2025 •

edited

Loading

youmeim commented Jun 25, 2025 •

edited

Loading

youmeim commented Jul 1, 2025 •

edited

Loading