[12.x] Resolve issue with creating event and automatic eager loading #56208
+81
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eager loading automatically, when the creating event & others occur via observers, or models. I noticed during tests that relationships would be set as null when using saveMany etc- where as previously without eager loading automatically they would work.
This means tests would begin to fail.
I've added a test for this behavior & removing the HasEvent changes I've made it fails.
The logic I've added removes any relations that have been set as null before the creating event, and call the eager loading chain again meaning those relations will be set properly. Because it's the first event called (I believe) it means other events no longer suffer this too.
Perhaps there's a better way, but open to ideas.