Description
This task is tricky and requires investigation on the approach to mock static calls without Aspect Mock
Goal
codeception/aspect-mock library is still not compatible with PHP 8.0 at the time of the creation of this ticket.
To speed up Magento compatibility with new PHP versions we'd like to eliminate codeception/aspect-mock dependency from MFTF. This will make MFTF compatible with PHP 8.0 that is required for declaring the Magento core PHP 8 compatible as well.
In order to do this existing unit tests using AspectMock should be refactored to use PHPUnit instead.
Task
Eliminate AspectMock usage from \tests\unit\Util\ObjectHandlerUtil in https://github.com/magento/magento2-functional-testing-framework repository.
Example
Mocking an object using AspectMock (current):
$mock = AspectMock::double(
MockedClass::class,
[
'mockedMethodName' => 'methodReturnValue',
]
)->make();
Mocking an object using PHPUnit (refactored code):
$mock = $this->createMock(File::class);
$file->expects($this->any())
->method('mockedMethodName')
->willReturn('methodReturnValue');
Example pull request: magento/magento2-functional-testing-framework#833
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Participants
Activity
m2-assistant commentedon Jul 26, 2021
Hi @bohdan-harniuk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance- upcoming 2.4.x releaseFor more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue:
@magento I am working on this🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
m2-assistant commentedon Jul 26, 2021
Hi @bohdan-harniuk. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the labelIssue: Format is validwill be added to the issue automatically. Please, edit issue description if needed, until labelIssue: Format is validappears.2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add
Issue: Clear Descriptionlabel to the issue by yourself.3. Add
Component: XXXXXlabel(s) to the ticket, indicating the components it may be related to.4. Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-developbranch, please, add the labelReproduced on 2.4.x.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label
Issue: Confirmedonce verification is complete.6. Make sure that automatic system confirms that report has been added to the backlog.
m2-assistant commentedon Jul 26, 2021
Hi @anzin. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Details
If the issue has a valid description, the labelIssue: Format is validwill be added to the issue automatically. Please, edit issue description if needed, until labelIssue: Format is validappears.Issue: Clear Descriptionlabel to the issue by yourself.Component: XXXXXlabel(s) to the ticket, indicating the components it may be related to.2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-developbranch, please, add the labelReproduced on 2.4.x.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
9 remaining items