Fix encoding issue when secret key contains plus sign #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If some of the
REMOTE_STORAGE_
options contain+
sign inside value the tests running will fail as here https://github.com/magento-commerce/magento2-functional-testing-framework/blob/develop/etc/config/command.php#L15 urldecode will remove pluses+
from command andsetup:config:set --remote-storage-driver=...
will fail withToo many arguments, expected arguments "command"
.I got this issue as the current
REMOTE_STORAGE_AWSS3_SECRET_KEY
value contains two + signs.I tried, with single quotes or double quotes but they are ignored and option values in command passing without quotes.
For example, I’ve set:
REMOTE_STORAGE_AWSS3_ACCESS_KEY='AKIAAFIELSFN+FNM7S2T+VORAXPQ'
command.php received:
php bin/magento setup:config:set ... --remote-storage-key=AKIAAFIELSFN+FNM7S2T+VORAXPQ
and after urldecode will be
php bin/magento setup:config:set ... --remote-storage-key=AKIAAFIELSFN FNM7S2T VORAXPQ
Fixed Issues (if relevant)
Contribution checklist