Skip to content

Fix #885 - Implement correct params on Vault PHP lib call #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

Fix #885 - Implement correct params on Vault PHP lib call #886

merged 1 commit into from
May 6, 2022

Conversation

jonatanrdsantos
Copy link
Member

Description

Fixed Issues (if relevant)

  1. Hashicorp Vault PHP lib being instantiated with wrong params #885

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jonatanrdsantos jonatanrdsantos force-pushed the hotfix/issue-885-vault-with-wrong-params branch from dcff027 to 64b13bc Compare February 15, 2022 22:53
@okolesnyk
Copy link
Member

Hi @jonatanrdsantos

I finally started working on delivery of this PR
If you don't mind could you please pull develop branch to yours so that it's up to date

Thanks

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit eb1bbaf into magento:develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Award: advanced has-jira-ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonatanrdsantos @okolesnyk @magento-devops-reposync-svc