Skip to content

[Issue] Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348) #39340

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #39331: Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348)


Description (*)

This Pull Request fixes misleading method declarations for Abstract Item methods.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Nov 7, 2024
self-assigned this
on Nov 8, 2024
m2-assistant

m2-assistant commented on Nov 8, 2024

@m2-assistant
Author

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-Hotel

engcom-Hotel commented on Nov 8, 2024

@engcom-Hotel
Contributor

Hello @lbajsarowicz,

Thanks for the report and collaboration!

As nothing needs to be reproduced on this issue, we are confirming this issue by looking into the code changes.

Thanks

github-jira-sync-bot

github-jira-sync-bot commented on Nov 8, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13334 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Nov 8, 2024

@m2-assistant
Author

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: Cart & CheckoutComponent: QuoteIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @lbajsarowicz@engcom-Hotel@github-jira-sync-bot

    Issue actions

      [Issue] Developer Experience: Quote AbstractItem code style (SwiftOtter's SOP-348) · Issue #39340 · magento/magento2